Skip to content

ENH: Implement EA unary ops #23313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 25 commits into from
Closed

ENH: Implement EA unary ops #23313

Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
4188e9f
ENH: Implement EA unary ops
sinhrks Oct 24, 2018
6e5cf3d
Fixed test for older NumPy ver
sinhrks Jan 15, 2019
3b3003f
Fixed tests for latest numpy
sinhrks Jan 15, 2019
e0b37ae
updated doc
sinhrks Jan 15, 2019
6476d0d
Additional fixes
sinhrks Jan 17, 2019
528e4d1
Remove unary method from DatetimeArray
sinhrks Jan 22, 2019
dbdce23
move __pos__ logic to ExtensionArray
sinhrks Jan 23, 2019
af84599
Merge remote-tracking branch 'upstream/master' into unary
WillAyd Jun 8, 2019
b0975f4
Reverted bad merge of 24 whatsnew
WillAyd Jun 8, 2019
8e3638c
Removed Panel-specific code
WillAyd Jun 8, 2019
63430e7
Added stdlib operator import
WillAyd Jun 10, 2019
9fe6085
Merge remote-tracking branch 'upstream/master' into unary
WillAyd Jun 10, 2019
b6430f1
Removed old np13 check
WillAyd Jun 10, 2019
736fc27
Fixed wrong error msg expectation
WillAyd Jun 10, 2019
87b8cab
lint fixup
WillAyd Jun 10, 2019
c6437ba
Merge remote-tracking branch 'upstream/master' into unary
WillAyd Jun 11, 2019
91a7fec
Added warnings catch for operator pos
WillAyd Jun 11, 2019
b221fd0
lint fixup
WillAyd Jun 11, 2019
0afef3c
Reverted warnings catch
WillAyd Jun 11, 2019
4c322b6
Reimplemented warnings catch for np dev
WillAyd Jun 11, 2019
2b480be
test fixup
WillAyd Jun 11, 2019
ad62830
Used OrderedDict for py35 compat
WillAyd Jun 11, 2019
0d6e0c5
Changed to tm.assert_produces_warning
WillAyd Jun 11, 2019
4f6d656
Merge remote-tracking branch 'upstream/master' into unary
WillAyd Jun 30, 2019
536d002
Fixed bad imports
WillAyd Jun 30, 2019
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Changed to tm.assert_produces_warning
  • Loading branch information
@WillAyd
WillAyd committed Jun 11, 2019
commit 0d6e0c58898cc82d1bd86779dbc99c1f7f8ff1c5
2 changes: 1 addition & 1 deletion pandas/tests/series/test_arithmetic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,7 @@ def test_bool(self, typ, op):
result = op(ser)
if op is operator.pos and pd.compat.numpy._is_numpy_dev:
Copy link
Member

@WillAyd WillAyd Jun 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how this is going to hold up. w.r.t the linked issue:

numpy/numpy#11450

That was milestoned for numpy 1.16 but interestingly only appears in dev with this change.
# behavior change due to np#11450 ?
with pytest.warns(DeprecationWarning, match="ill-defined"):
with tm.assert_produces_warning(DeprecationWarning):
values = op(ser.values)
else:
values = op(ser.values)
Expand Down