Skip to content

DOC: Improve "inplace" param in Dataframe.rename() docs #24037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

DOC: Improve "inplace" param in Dataframe.rename() docs #24037

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
38f2a80
DOC: Improve "inplace" param in Dataframe.rename() docs
nmusolino Dec 1, 2018
f273ef0
TST: Assert result of in-place rename is None
nmusolino Dec 1, 2018
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
TST: Assert result of in-place rename is None
  • Loading branch information
@nmusolino
nmusolino committed Dec 1, 2018
commit f273ef05303797c8992c4402bf1d5e6e18f23daf
3 changes: 2 additions & 1 deletion pandas/tests/frame/test_alter_axes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -678,8 +678,9 @@ def test_rename_inplace(self, float_frame):

c_id = id(float_frame['C'])
float_frame = float_frame.copy()
float_frame.rename(columns={'C': 'foo'}, inplace=True)
result = float_frame.rename(columns={'C': 'foo'}, inplace=True)

assert result is None
assert 'C' not in float_frame
assert 'foo' in float_frame
assert id(float_frame['foo']) != c_id
Expand Down