Skip to content

Conversation

@jreback
Copy link
Contributor

@jreback jreback commented Jan 3, 2019

xref #15889

@jreback jreback added Docs 32bit 32-bit systems labels Jan 3, 2019
@jreback jreback added this to the 0.24.0 milestone Jan 3, 2019
@jreback
Copy link
Contributor Author

jreback commented Jan 3, 2019

@codecov
Copy link

codecov bot commented Jan 3, 2019

Codecov Report

Merging #24588 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@ ## master #24588 +/- ## ======================================= Coverage 92.36% 92.36% ======================================= Files 166 166 Lines 52497 52497 ======================================= Hits 48489 48489 Misses 4008 4008
Flag Coverage Δ
#multiple 90.79% <ø> (ø) ⬆️
#single 43.04% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0039158...c4deb74. Read the comment docs.

@codecov
Copy link

codecov bot commented Jan 3, 2019

Codecov Report

Merging #24588 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@ ## master #24588 +/- ## ======================================= Coverage 92.38% 92.38% ======================================= Files 166 166 Lines 52490 52490 ======================================= Hits 48493 48493 Misses 3997 3997
Flag Coverage Δ
#multiple 90.81% <ø> (ø) ⬆️
#single 43.05% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6249355...0fb5bc9. Read the comment docs.

Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dropping 32-bit support, was this already discussed somewhere recently? (the linked issue seems to be mainly older comments)

Co-Authored-By: jreback <jeff@reback.net>
@jreback
Copy link
Contributor Author

jreback commented Jan 3, 2019

Dropping 32-bit support, was this already discussed somewhere recently? (the linked issue seems to be mainly older comments)

I am just linking for posterity.

@jorisvandenbossche
Copy link
Member

I am just linking for posterity.

I understand, but that means we decided to drop 32-bit support for 0.25.0 ?
And my question was: is there a discussion somewhere about this decision? (I don't think I am opposed, but still good to have this decision recorded somewhere)

@jreback
Copy link
Contributor Author

jreback commented Jan 3, 2019

that's the issue, this was long ago discussed. I see no reasont keep this burden (and actually the doc note is just to say we are going to do it).

@jbrockmendel
Copy link
Member

There was some discussion of finding out usage stats for 32bit python on windows. Did anything come of that?

@TomAugspurger
Copy link
Contributor

TomAugspurger commented Jan 3, 2019 via email

@jreback
Copy link
Contributor Author

jreback commented Jan 3, 2019

thanks @TomAugspurger yeah main motivation is that we don't have great testing, its just daily and hard to repro / fix.

@TomAugspurger
Copy link
Contributor

TomAugspurger commented Jan 3, 2019 via email

@jreback
Copy link
Contributor Author

jreback commented Jan 3, 2019

no we only test on 64-bit windows

@jreback
Copy link
Contributor Author

jreback commented Jan 3, 2019

in fact we only here about 32-bit windows at release time I think (when wheels are built)

@jreback
Copy link
Contributor Author

jreback commented Jan 3, 2019

any objections?

@jorisvandenbossche
Copy link
Member

@jreback can you raise this again in the original issue (#15889), and give people that participated there some time to respond?

(@TomAugspurger can you repeat those numbers there?)

@jorisvandenbossche
Copy link
Member

@jreback I already applied the part of this commit about the py27 warning to master and merged master in your branch. So now this is only about 32bit.

@jreback jreback closed this Jan 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

32bit 32-bit systems Docs

4 participants