Skip to content

DOC: Fixes to docstrings and add PR10 (space before colon) to validation #25109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 8, 2019
+5 −5
Merged

DOC: Fixes to docstrings and add PR10 (space before colon) to validation #25109

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
da5669e
added type set_option docstring in config.py
Feb 3, 2019
6004ac3
added type to boxplot_frame_groupby docstring in plotting/_corew.py
Feb 3, 2019
bacc17a
indented versionadded in ExcelWriter docstring io/excel.py
Feb 3, 2019
6d6e054
updated code_check.sh to take into account PR10 type errors
Feb 3, 2019
dcf11aa
updated type in plotting/_core.py
Feb 4, 2019
d07e63b
Resolved conflict by incorporating both suggestions.
Feb 7, 2019
fc8b1c4
modified type to object for value variable in config.py
Feb 7, 2019
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
updated code_check.sh to take into account PR10 type errors
  • Loading branch information
Víctor Moron authored and Víctor Moron committed Feb 3, 2019
commit 6d6e0544255b3a8f4806d7044ec34f2ed40405f7
4 changes: 2 additions & 2 deletions ci/code_checks.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,8 +240,8 @@ fi
### DOCSTRINGS ###
if [[ -z "$CHECK" || "$CHECK" == "docstrings" ]]; then

MSG='Validate docstrings (GL06, GL07, GL09, SS04, PR03, PR05, EX04)' ; echo $MSG
$BASE_DIR/scripts/validate_docstrings.py --format=azure --errors=GL06,GL07,GL09,SS04,PR03,PR05,EX04
MSG='Validate docstrings (GL06, GL07, GL09, SS04, PR03, PR05, PR10, EX04)' ; echo $MSG
$BASE_DIR/scripts/validate_docstrings.py --format=azure --errors=GL06,GL07,GL09,SS04,PR03,PR05,PR10,EX04
RET=$(($RET + $?)) ; echo $MSG "DONE"

fi
Expand Down