BUG: Rewrite _make_concat_multiindex #25117
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Hello @toobaz! Thanks for updating the PR. Cheers ! There are no PEP8 issues in this Pull Request. 🍻 Comment last updated on February 03, 2019 at 15:53 Hours UTC |
toobaz force-pushed the concat_mi_append_20565 branch from 7d6d8f9 to c9898c1 Compare 
jreback requested changes Feb 3, 2019
Contributor
jreback left a comment
jreback left a comment There was a problem hiding this comment.
small comments. otherwise nice cleaning.
| | ||
| - Bug in :func:`merge` when merging by index name would sometimes result in an incorrectly numbered index (:issue:`24212`) | ||
| - :func:`to_records` now accepts dtypes to its `column_dtypes` parameter (:issue:`24895`) | ||
| - Bug in :func:`concat` creating a malformed :class:`MultiIndex` when passed multiple frames indexed by identical :class:`MultiIndex`es (:issue:`20565`) |
Contributor
There was a problem hiding this comment.
you need a space before the es I think
| tupleize_cols=True) | ||
| tot_df = concat([keys_levs.to_frame().reset_index(drop=True), | ||
| orig.to_frame().reset_index(drop=True)], axis=1) | ||
| temp_names = [None] * keys_levs.nlevels + list(orig.names) |
| # Received names for all levels | ||
| result.names = names | ||
| | ||
| if levels is not None: |
Contributor
There was a problem hiding this comment.
can you add some commentary what you are doing here
mroeschke reviewed Feb 4, 2019
| orig = _concat_indexes(indexes) | ||
| | ||
| # Simplest way to create and prepend the keys level(s): | ||
| keys_chunks = [([key] * len(idx)) for (key, idx) in zip(keys, indexes)] |
Member
There was a problem hiding this comment.
Maybe make this a generator comprehension instead
Contributor
| closing as stale |
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diff