Skip to content

CI: add __init__.py to isort skip list #25455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 27, 2019
Merged

CI: add __init__.py to isort skip list #25455

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
06ef7b4
CI: add __init__.py to isort skip list
simonjayhawkins Feb 26, 2019
674d42d
add isort to each of the ci/deps files
simonjayhawkins Feb 27, 2019
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
CI: add __init__.py to isort skip list
  • Loading branch information
@simonjayhawkins
simonjayhawkins committed Feb 26, 2019
commit 06ef7b489079839cd001b3020d87e7908a937a90
20 changes: 20 additions & 0 deletions setup.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,3 +152,23 @@ skip=
asv_bench/benchmarks/dtypes.py
asv_bench/benchmarks/strings.py
asv_bench/benchmarks/period.py
pandas/__init__.py
Copy link
Contributor

@jreback jreback Feb 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what i mean is, can you just run isort on these?
Copy link
Contributor

@jreback jreback Feb 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

o i guess could be a followup
Copy link
Member Author

@simonjayhawkins simonjayhawkins Feb 27, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

running isort on all the __init__.py files gives..

ImportError while loading conftest 'C:\Users\simon\OneDrive\code\pandas-simonjayhawkins\pandas\conftest.py'. pandas\__init__.py:29: in <module> import pandas.arrays pandas\arrays\__init__.py:6: in <module> from pandas.core.arrays import ( pandas\core\arrays\__init__.py:4: in <module> from .categorical import Categorical # noqa pandas\core\arrays\categorical.py:33: in <module> from pandas.core.base import NoNewAttributesMixin, PandasObject, _shared_docs pandas\core\base.py:27: in <module> import pandas.core.nanops as nanops pandas\core\nanops.py:54: in <module> set_use_bottleneck(get_option('compute.use_bottleneck')) pandas\core\config.py:227: in __call__ return self.__func__(*args, **kwds) pandas\core\config.py:97: in _get_option key = _get_single_key(pat, silent) pandas\core\config.py:83: in _get_single_key raise OptionError('No such keys(s): {pat!r}'.format(pat=pat)) E pandas.core.config.OptionError: "No such keys(s): 'compute.use_bottleneck'"

so some work required to do this.
Copy link
Contributor

@jreback jreback Feb 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gotcha ok then
Copy link
Member Author

@simonjayhawkins simonjayhawkins Feb 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also i'm on Windows and not able to run isort 4.3.8 because of PyCQA/isort#835, so struggling to make progress on this.
Copy link
Contributor

@jreback jreback Feb 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, can you post an issue about this
Copy link
Member Author

@simonjayhawkins simonjayhawkins Feb 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need a separate issue? #23334 is still open. add to that?
Copy link
Contributor

@jreback jreback Feb 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's add to that one.
pandas/plotting/__init__.py
pandas/tests/extension/decimal/__init__.py
pandas/tests/extension/base/__init__.py
pandas/io/msgpack/__init__.py
pandas/io/json/__init__.py
pandas/io/clipboard/__init__.py
pandas/io/excel/__init__.py
pandas/compat/__init__.py
pandas/compat/numpy/__init__.py
pandas/core/arrays/__init__.py
pandas/core/groupby/__init__.py
pandas/core/internals/__init__.py
pandas/api/__init__.py
pandas/api/extensions/__init__.py
pandas/api/types/__init__.py
pandas/_libs/__init__.py
pandas/_libs/tslibs/__init__.py
pandas/util/__init__.py
pandas/arrays/__init__.py