Skip to content

Draft implementation #25463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Draft implementation #25463

wants to merge 2 commits into from

Conversation

@samuelsinayoko
Copy link
Contributor

@samuelsinayoko samuelsinayoko commented Feb 27, 2019

Raises a ValueError when the input to to_datetime contains some numbers
but the unit isn't supplied.
@samuelsinayoko
Draft implementation
b37466f 
Raises a ValueError when the input to to_datetime contains some numbers but the unit isn't supplied.
@pep8speaks
Copy link

pep8speaks commented Feb 27, 2019 •
edited
Loading

Hello @samuelsinayoko! Thanks for updating the PR.

Cheers ! There are no PEP8 issues in this Pull Request. 🍻

Comment last updated on February 27, 2019 at 20:35 Hours UTC
@gfyoung gfyoung added Datetime Datetime data dtype API Design labels Feb 28, 2019
@gfyoung gfyoung requested review from jreback and mroeschke and removed request for jreback February 28, 2019 04:06
@WillAyd
Copy link
Member

WillAyd commented Feb 28, 2019

First part of any PR should be tests so please make sure to add them. Also looks like this introduced a slew of errors so be sure to run the suite locally before pushing to GH
@chris-b1 chris-b1 mentioned this pull request Mar 15, 2019
Closed
@WillAyd
Copy link
Member

WillAyd commented Mar 22, 2019

Closing as stale - ping if you'd like to pick this back up and have tests
@WillAyd WillAyd closed this Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API Design Datetime Datetime data dtype

4 participants

@samuelsinayoko @pep8speaks @WillAyd @gfyoung