Skip to content

Remove pandas.core.index.datetimelike from MyPy Blacklist #26280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jun 25, 2019
Merged

Remove pandas.core.index.datetimelike from MyPy Blacklist #26280

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
a3a1605
Add type annotation and remove blacklist item
makbigc May 4, 2019
9c60e73
isort datetimelike.py
makbigc May 8, 2019
717bb83
Add comment for the need of type: ignore
makbigc May 8, 2019
4b3af23
merge
makbigc May 30, 2019
29dbd92
Add ignore comment
makbigc May 30, 2019
213af4a
Add annotation DatetimeLikeArray to _data
makbigc Jun 10, 2019
a5f7d7b
resolve conflict
makbigc Jun 10, 2019
b7f5a9c
Import EA directly
makbigc Jun 11, 2019
2bd7542
Removed DatetimeLikeArray TypeVar for now
WillAyd Jun 24, 2019
d9ab7b0
Removed DatetimeLikeArray annotations
WillAyd Jun 24, 2019
dea0cb1
isort fixup
WillAyd Jun 25, 2019
b061ac1
Update _typing.py
WillAyd Jun 25, 2019
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add ignore comment
  • Loading branch information
@makbigc
makbigc committed May 30, 2019
commit 29dbd929942d28d952964118d069559dbcc0b4b2
16 changes: 10 additions & 6 deletions pandas/core/indexes/datetimelike.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,12 +63,16 @@ class DatetimeIndexOpsMixin(ExtensionOpsMixin):
# DatetimeLikeArrayMixin assumes subclasses are mutable, so these are
# properties there. They can be made into cache_readonly for Index
# subclasses bc they are immutable
inferred_freq = cache_readonly(DatetimeLikeArrayMixin.inferred_freq.fget)
_isnan = cache_readonly(DatetimeLikeArrayMixin._isnan.fget)
hasnans = cache_readonly(DatetimeLikeArrayMixin._hasnans.fget)
inferred_freq = cache_readonly(
DatetimeLikeArrayMixin.inferred_freq.fget) # type: ignore
_isnan = cache_readonly(DatetimeLikeArrayMixin._isnan.fget) # type: ignore
hasnans = cache_readonly(
DatetimeLikeArrayMixin._hasnans.fget) # type: ignore
_hasnans = hasnans # for index / array -agnostic code
_resolution = cache_readonly(DatetimeLikeArrayMixin._resolution.fget)
resolution = cache_readonly(DatetimeLikeArrayMixin.resolution.fget)
_resolution = cache_readonly(
DatetimeLikeArrayMixin._resolution.fget) # type: ignore
resolution = cache_readonly(
DatetimeLikeArrayMixin.resolution.fget) # type: ignore

_maybe_mask_results = ea_passthrough(
DatetimeLikeArrayMixin._maybe_mask_results)
Expand Down Expand Up @@ -130,7 +134,7 @@ def _ndarray_values(self):
# Abstract data attributes

@property
Copy link
Contributor

@jreback jreback May 30, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this change?
Copy link
Contributor Author

@makbigc makbigc May 30, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mypy has the following error for the annotated value function:

pandas/core/indexes/datetimelike.py:139: error: "None" has no attribute "_data"

I add annotation # type: DatetimeArray to _data. But mypy still has the same error.

pandas/pandas/core/indexes/datetimes.py

Line 327 in 8154efb

result._data = dtarr

I guess that mypy mixed up the instance attribute _data with the class attributes _data which is set None in the beginning of DatetimeIndexOpsMixin.
Copy link
Contributor

@jreback jreback May 30, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @WillAyd
Copy link
Member

@WillAyd WillAyd Jun 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry missed this ping. This could be a similar conversation to https://github.com/pandas-dev/pandas/pull/26518/files#r287573810
Copy link
Member

@WillAyd WillAyd Jun 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a better solution is to provide the appropriate type to _data. Can you create a DatetimeLikeArray in pandas._typing which should be something like DatetimeLikeArray = TypeVar('DatetimeLikeArray', DatetimeArray, PeriodArray, TimedeltaArray) and assign that type to _data in the class? I think that should resolve.

cc @jbrockmendel in case he has other insights on the types here
def values(self) -> np.ndarray:
def values(self):
# Note: PeriodArray overrides this to return an ndarray of objects.
return self._data._data

Expand Down