Skip to content

Conversation

@alimcmaster1
Copy link
Member

@alimcmaster1 alimcmaster1 commented Jun 5, 2019

#LondonPythonSprints

@pep8speaks
Copy link

pep8speaks commented Jun 5, 2019

Hello @alimcmaster1! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-06-08 11:14:01 UTC
@simonjayhawkins simonjayhawkins added CI Continuous Integration Dependencies Required and optional dependencies labels Jun 5, 2019
@datapythonista
Copy link
Member

@alimcmaster1 can you please rebase? I think there was something wrong in master that was causing the CI to be red.

Also, do you mind editing the description with info about the changes not directly specified in the ticket. Was it required for the issue to fix the sorts in the files you removed from setup.cfg, or are they unrelated to the changes in the dependencies?

@codecov
Copy link

codecov bot commented Jun 8, 2019

Codecov Report

Merging #26671 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@ Coverage Diff @@ ## master #26671 +/- ## ========================================== - Coverage 91.78% 91.77% -0.01%  ========================================== Files 174 174 Lines 50703 50712 +9 ========================================== + Hits 46538 46543 +5  - Misses 4165 4169 +4
Flag Coverage Δ
#multiple 90.37% <100%> (ø) ⬆️
#single 41.82% <100%> (-0.08%) ⬇️
Impacted Files Coverage Δ
pandas/_libs/__init__.py 100% <ø> (ø) ⬆️
pandas/_libs/tslibs/__init__.py 100% <100%> (ø) ⬆️
pandas/compat/numpy/__init__.py 93.1% <100%> (ø) ⬆️
pandas/api/extensions/__init__.py 100% <100%> (ø) ⬆️
pandas/core/internals/__init__.py 100% <100%> (ø) ⬆️
pandas/core/arrays/__init__.py 100% <100%> (ø) ⬆️
pandas/api/types/__init__.py 100% <100%> (ø) ⬆️
pandas/io/clipboard/__init__.py 54.34% <100%> (ø) ⬆️
pandas/io/excel/__init__.py 100% <100%> (ø) ⬆️
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf25c5c...9a3dcd8. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 8, 2019

Codecov Report

Merging #26671 into master will decrease coverage by 49.99%.
The diff coverage is 100%.

Impacted file tree graph

@@ Coverage Diff @@ ## master #26671 +/- ## ========================================== - Coverage 91.78% 41.79% -50%  ========================================== Files 174 174 Lines 50703 50672 -31 ========================================== - Hits 46538 21177 -25361  - Misses 4165 29495 +25330
Flag Coverage Δ
#multiple ?
#single 41.79% <100%> (-0.11%) ⬇️
Impacted Files Coverage Δ
pandas/_libs/__init__.py 100% <ø> (ø) ⬆️
pandas/_libs/tslibs/__init__.py 100% <100%> (ø) ⬆️
pandas/compat/numpy/__init__.py 79.31% <100%> (-13.8%) ⬇️
pandas/api/extensions/__init__.py 100% <100%> (ø) ⬆️
pandas/core/internals/__init__.py 100% <100%> (ø) ⬆️
pandas/core/arrays/__init__.py 100% <100%> (ø) ⬆️
pandas/api/types/__init__.py 100% <100%> (ø) ⬆️
pandas/io/clipboard/__init__.py 54.34% <100%> (ø) ⬆️
pandas/io/excel/__init__.py 100% <100%> (ø) ⬆️
pandas/io/formats/latex.py 0% <0%> (-100%) ⬇️
... and 138 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf25c5c...9a3dcd8. Read the comment docs.

@alimcmaster1
Copy link
Member Author

@datapythonista - ill split this PR up I was removing the isort dependency and isorting some files and - the two are independent - see here for new PR: #26732

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Continuous Integration Dependencies Required and optional dependencies

4 participants