BUG: .isin on datetimelike indexes do not validate input of level parameter #26677
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
simonjayhawkins added Index 
WillAyd reviewed Jun 5, 2019
pandas/tests/indexes/conftest.py Outdated
| | ||
| | ||
| all_indexes = [index for index in ([Index] + list(set(_get_subclasses(Index)))) | ||
| if getattr(pd, index.__name__, None) is not None] |
Member
There was a problem hiding this comment.
Can just simplify to if getattr(pd, index.__name__, False)
Member Author
There was a problem hiding this comment.
missed that. thanks.
Member Author
| To exclude IntegerIndex and NumericIndex classes. But ci failed. so may need rethink. the idea was to create a fixture that checks all registered indexes for API checking. May just have to list them explicitly for now …On Wed, 5 Jun 2019, 22:41 William Ayd, ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In pandas/tests/indexes/conftest.py <#26677 (comment)>: > @@ -47,3 +47,37 @@ def zero(request): # For testing division by (or of) zero for Index with length 5, this # gives several scalar-zeros and length-5 vector-zeros return request.param + + +def _get_subclasses(cls): + for subclass in cls.__subclasses__(): + yield from _get_subclasses(subclass) + yield subclass + + +all_indexes = [index for index in ([Index] + list(set(_get_subclasses(Index)))) + if getattr(pd, index.__name__, None) is not None] What is the name check for? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#26677?email_source=notifications&email_token=ADEMUXMUFATJ3BCOVTBNL6DPZAXI7A5CNFSM4HUE47D2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB2W5INA#pullrequestreview-246273076>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADEMUXMV4FAGWFTTC36THYDPZAXI7ANCNFSM4HUE47DQ> . |
simonjayhawkins changed the title 
Codecov Report
@@ Coverage Diff @@ ## master #26677 +/- ## =========================================== - Coverage 91.88% 41.78% -50.11% =========================================== Files 174 174 Lines 50694 50665 -29 =========================================== - Hits 46581 21169 -25412 - Misses 4113 29496 +25383
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@ ## master #26677 +/- ## ========================================= + Coverage 90.3% 91.7% +1.4% ========================================= Files 179 179 Lines 50747 50749 +2 ========================================= + Hits 45826 46540 +714 + Misses 4921 4209 -712
Continue to review full report at Codecov.
|
Member Author
| @WillAyd the ci failures are now fixed. but could still parametrise |
WillAyd requested changes Jun 6, 2019
Member
WillAyd left a comment
WillAyd left a comment There was a problem hiding this comment.
Minor stylistic nit but otherwise lgtm
pandas/tests/indexes/conftest.py Outdated
| | ||
| | ||
| all_indexes = [index for index in ([Index] + list(set(_get_subclasses(Index)))) | ||
| if getattr(pd, index.__name__, None) is not None] |
Member
There was a problem hiding this comment.
Can just simplify to if getattr(pd, index.__name__, False)
WillAyd approved these changes Jun 6, 2019
jreback requested changes Jun 8, 2019
pandas/tests/indexes/conftest.py Outdated
| return request.param | ||
| | ||
| | ||
| @pytest.fixture |
Contributor
There was a problem hiding this comment.
shouldn't this just work off of the indices_list? why creating extra machinery here?
jreback approved these changes Jun 9, 2019
Contributor
| thanks @simonjayhawkins |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
#LondonPythonSprints
git diff upstream/master -u -- "*.py" | flake8 --diff