Skip to content

COMPAT: 32-bit nargsort #27064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 27, 2019
Merged

COMPAT: 32-bit nargsort #27064

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0c70c3e
COMPAT: 32-bit nargsort
TomAugspurger Jun 26, 2019
bd06a0c
Merge remote-tracking branch 'upstream/master' into wheel-fikxup
TomAugspurger Jun 27, 2019
631be47
try intp?
TomAugspurger Jun 27, 2019
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
COMPAT: 32-bit nargsort 
MacPython/pandas-wheels#51
  • Loading branch information
@TomAugspurger
TomAugspurger committed Jun 26, 2019
commit 0c70c3e4dd2ad54d88e955933fee2dc2494dce0e
4 changes: 2 additions & 2 deletions pandas/tests/extension/base/methods.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,8 @@ def test_argsort_missing(self, data_missing_for_sorting):
self.assert_series_equal(result, expected)

@pytest.mark.parametrize('na_position, expected', [
('last', np.array([2, 0, 1], dtype='int64')),
('first', np.array([1, 2, 0], dtype='int64'))
('last', np.array([2, 0, 1], dtype='int')),
Copy link
Contributor

@jreback jreback Jun 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm this is failing on windows, maybe you need intp here?
('first', np.array([1, 2, 0], dtype='int'))
])
def test_nargsort(self, data_missing_for_sorting, na_position, expected):
# GH 25439
Expand Down