TYPING: pandas/core/window.py #27391
Conversation
mroeschke added Typing 
WillAyd left a comment
WillAyd left a comment There was a problem hiding this comment.
Looks pretty good - just a few things. Thanks for taking a look at this!
pandas/core/window.py Outdated
| min_periods: Optional[int] = None, | ||
| center: Optional[bool] = False, | ||
| win_type: Optional[str] = None, | ||
| axis: Union[str, int] = 0, |
There was a problem hiding this comment.
Can you put this in pandas._typing as Axis and reference here?
cc @topper-123 as this might conflict with your other PR
pandas/core/window.py Outdated
| def _wrap_result(self, result, block=None, obj=None): | ||
| def _wrap_result( | ||
| self, result, block=None, obj=None | ||
| ) -> Union[ABCSeries, ABCDataFrame]: |
There was a problem hiding this comment.
Should use FrameOrSeries from pandas._typing
| "on", | ||
| "closed", | ||
| ] | ||
| ] # type: List[str] |
There was a problem hiding this comment.
Was this actually throwing an error? Not opposed to it just surprised Mypy wouldn't infer this already
There was a problem hiding this comment.
Don't think so; just thought to go ahead and type.
WillAyd left a comment
WillAyd left a comment There was a problem hiding this comment.
lgtm - thanks for typing and simplifying signatures
| Thanks for reviewing @WillAyd! |
* TYPING: pandas/core/window.py * Address comments * Remove unused import * Sort imports
| values = values.copy() | ||
| values[np.isinf(values)] = np.NaN | ||
| # Always convert inf to nan | ||
| values[np.isinf(values)] = np.NaN |
There was a problem hiding this comment.
You missed a copy call here. Results in kernc/backtesting.py#14 on write-protected arrays.
3 participants
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffIncludes simplifying some code paths