Skip to content

Series.rename now handles values by Series constructor #27975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Series.rename now handles values by Series constructor #27975

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
65ecd54
read_parquet now has path_to_directory accept info
prajvalgupta Aug 17, 2019
f8550d1
added example for scatter plot with best line fit
prajvalgupta Aug 17, 2019
037bc1d
added example for scatter plot with best line fit
prajvalgupta Aug 17, 2019
71bfe15
added example for scatter plot with best line fit
prajvalgupta Aug 17, 2019
b929efd
Series.rename now handles values by Series constructor
prajvalgupta Aug 17, 2019
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Series.rename now handles values by Series constructor
  • Loading branch information
@prajvalgupta
prajvalgupta committed Aug 17, 2019
commit b929efd65964c2bf51b6132af6aac07c8833daa0
8 changes: 3 additions & 5 deletions pandas/core/series.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4165,12 +4165,10 @@ def rename(self, index=None, **kwargs):
"""
kwargs["inplace"] = validate_bool_kwarg(kwargs.get("inplace", False), "inplace")

non_mapping = is_scalar(index) or (
is_list_like(index) and not is_dict_like(index)
)
if non_mapping:
if callable(index) or is_dict_like(index):
return super().rename(index=index, **kwargs)
else:
return self._set_name(index, inplace=kwargs.get("inplace"))
return super().rename(index=index, **kwargs)

@Substitution(**_shared_doc_kwargs)
@Appender(generic.NDFrame.reindex.__doc__)
Expand Down