Validate plot backend when setting. #28164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
```python In [1]: import pandas as pd In [2]: import sys In [3]: import types In [4]: module = types.ModuleType("foo") In [5]: sys.modules['foo'] = module In [6]: pd.set_option('plotting.backend', 'foo') --------------------------------------------------------------------------- ValueError Traceback (most recent call last) <ipython-input-6-123b6513deb2> in <module> ----> 1 pd.set_option('plotting.backend', 'foo') ... ~/sandbox/pandas/pandas/plotting/_core.py in _find_backend(backend) 1588 "top-level `.plot` method." 1589 ) -> 1590 raise ValueError(msg.format(name=backend)) 1591 1592 ValueError: Could not find plotting backend 'foo'. Ensure that you've installed the package providing the 'foo' entrypoint, or that the package has atop-level `.plot` method. ``` Closes pandas-dev#28163 
WillAyd requested changes Aug 28, 2019
Contributor Author
datapythonista approved these changes Aug 30, 2019
Member
datapythonista left a comment
datapythonista left a comment There was a problem hiding this comment.
lgtm, thanks for the fix
Contributor Author
| Merging later today if there aren't any objections. |
Member
| LGTM |
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
* Validate plot backend when setting. Closes pandas-dev#28163
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
* Validate plot backend when setting. Closes pandas-dev#28163
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Closes #28163