Skip to content

Conversation

@kognate
Copy link
Contributor

@kognate kognate commented Oct 1, 2019

adds a test to check for regressions later. Replacement PR for #28732

adds a test to check for regressions later.
@jreback jreback changed the title Added test to confirm fix for #28658 Error when adding 'm' to a Series of strings Oct 1, 2019
@jreback jreback added Testing pandas testing functions or related to the test suite Strings String extension data type and string data labels Oct 1, 2019
@jreback jreback added this to the 1.0 milestone Oct 1, 2019
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jorisvandenbossche jorisvandenbossche changed the title Error when adding 'm' to a Series of strings TST: add test to confirm adding 'm' to a Series of strings does not error Oct 2, 2019
Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@jorisvandenbossche jorisvandenbossche merged commit b298696 into pandas-dev:master Oct 2, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
bongolegend pushed a commit to bongolegend/pandas that referenced this pull request Jan 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Strings String extension data type and string data Testing pandas testing functions or related to the test suite

4 participants