Eliminated _WriterBase class, removed unused fixtures from methods in pandas/io/excel/test_writers.py #28753
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
dayoreke changed the title 
simonjayhawkins added Clean IO Excel 
gfyoung reviewed Oct 2, 2019
WillAyd reviewed Oct 2, 2019
Member
WillAyd left a comment
WillAyd left a comment There was a problem hiding this comment.
Thanks for taking a look - this one might be tricky. Do you see a good way to keep all of the fixtures together? The downside to this approach is its not very clear the order in which the fixtures and parameters are getting injected
Member
this addresses Eliminate _WriterBase class and engine and ext injected into tests #26662 (comment) from #26784 could split into two PRs if it makes it easier to review. |
WillAyd approved these changes Oct 7, 2019
Member
WillAyd left a comment
WillAyd left a comment There was a problem hiding this comment.
OK I am on board with this ex @simonjayhawkins outstanding comments
dayoreke force-pushed the eliminate_writer_base_class branch from f1dd871 to f2db75d Compare 13 tasks
Member
| test_basics_with_nan failing. |
simonjayhawkins approved these changes Oct 13, 2019
Member
simonjayhawkins left a comment
simonjayhawkins left a comment There was a problem hiding this comment.
@dayoreke lgtm. ping on green.
Member
| Thanks @dayoreke Very nice! |
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
… pandas/io/excel/test_writers.py (pandas-dev#28753)
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
… pandas/io/excel/test_writers.py (pandas-dev#28753)
bongolegend pushed a commit to bongolegend/pandas that referenced this pull request Jan 1, 2020
… pandas/io/excel/test_writers.py (pandas-dev#28753)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff