Skip to content

values=['c'] returns aggfunc on all columns, instead of just the passed column #29081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

values=['c'] returns aggfunc on all columns, instead of just the passed column #29081

wants to merge 3 commits into from

Conversation

@quanghm
Copy link

@quanghm quanghm commented Oct 18, 2019

@pep8speaks
Copy link

pep8speaks commented Oct 18, 2019 •
edited
Loading

Hello @quanghm! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-11-12 04:58:12 UTC
@quanghm quanghm changed the title values=['c'] returns aggfunc on all columns, instead of just the passed columns values=['c'] returns aggfunc on all columns, instead of just the passed column Oct 18, 2019
@jbrockmendel
Copy link
Member

jbrockmendel commented Oct 19, 2019

@quanghm can you add tests for the bug this fixes
@quanghm
Copy link
Author

quanghm commented Oct 20, 2019

@quanghm can you add tests for the bug this fixes

@jbrockmendel I'm not sure how to add the tests. Can you point to some links? Thanks.
@jbrockmendel
Copy link
Member

jbrockmendel commented Oct 21, 2019

I'm not sure how to add the tests. Can you point to some links?

Take a look in pandas/tests/groupby/ for examples
@WillAyd
Copy link
Member

WillAyd commented Nov 7, 2019

@quanghm is this still active? Can you add tests?
@quanghm
Copy link
Author

quanghm commented Nov 8, 2019

@quanghm is this still active? Can you add tests?

Sorry, has been caught at work lately. I'll write the test over the weekend.
@jbrockmendel jbrockmendel added the Apply Apply, Aggregate, Transform, Map label Nov 18, 2019
@WillAyd
Copy link
Member

WillAyd commented Dec 17, 2019

@quanghm looks like CI is failing - can you take a look?
@jreback
Copy link
Contributor

jreback commented Jan 1, 2020

closing as stale. if you'd like to continue, pls ping. this needs tests.
@jreback jreback closed this Jan 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Apply Apply, Aggregate, Transform, Map

5 participants

@quanghm @pep8speaks @jbrockmendel @WillAyd @jreback