REF: separate out ShallowMixin #29427
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
gfyoung added Internals 
gfyoung reviewed Nov 6, 2019
Member
gfyoung left a comment
gfyoung left a comment There was a problem hiding this comment.
https://dev.azure.com/pandas-dev/pandas/_build/results?buildId=20252
Okay, so at least it's not just me who's getting that weird numpy dev failure
jreback approved these changes Nov 6, 2019
Contributor
| thanks @jbrockmendel |
Reksbril pushed a commit to Reksbril/pandas that referenced this pull request Nov 18, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffStops catching DataError in the 1D case for _aggregate_multiple_funcs. This change is mostly unrelated, but shares the process of reasoning about what cases need _shallow_copy/DataError.