Skip to content

Conversation

@Dr-Irv
Copy link
Contributor

@Dr-Irv Dr-Irv commented Jan 6, 2020

For @jreback to review based on his comment previous PR #30656

In a few files (see below), left it as is because usage was pretty local (and allows pd.arrays.SparseArray reference to be tested in code)

$ grep -c -r arrays.SparseArray . | grep -v ":0" ./dtypes/test_generic.py:1 ./frame/methods/test_quantile.py:2 ./series/test_missing.py:2
@TomAugspurger
Copy link
Contributor

My style preference is to just use pd.arrays namespace.

@Dr-Irv
Copy link
Contributor Author

Dr-Irv commented Jan 7, 2020

My style preference is to just use pd.arrays namespace.

So in the various test modules,
So @TomAugspurger prefers to use pd.arrays.SparseArray, i.e., writing pd.arrays.SparseArray([1,2,3]) in a test.
And @jreback prefers to from pd.arrays import SparseArray, i.e., writing SparseArray([1,2,3]) in a test

I did the latter because of feedback from @jreback , so you guys need to work out your differences.

@TomAugspurger
Copy link
Contributor

TomAugspurger commented Jan 7, 2020 via email

@jreback jreback added the Testing pandas testing functions or related to the test suite label Jan 7, 2020
@jreback
Copy link
Contributor

jreback commented Jan 7, 2020

this looks fine to me, i slightly prefer the shorter syntax. unless @TomAugspurger objects, ok to merge this.

@TomAugspurger
Copy link
Contributor

TomAugspurger commented Jan 7, 2020 via email

@jreback jreback added this to the 1.0 milestone Jan 8, 2020
@jreback jreback merged commit 4a039c6 into pandas-dev:master Jan 8, 2020
@Dr-Irv Dr-Irv deleted the tstsparse branch January 10, 2020 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Testing pandas testing functions or related to the test suite

3 participants