ENH: Implement DataFrame.value_counts #31247
Conversation
WillAyd left a comment
WillAyd left a comment There was a problem hiding this comment.
some minor nits on annotations but otherwise lgtm
Co-Authored-By: William Ayd <william.ayd@icloud.com>
Co-Authored-By: William Ayd <william.ayd@icloud.com>
pandas/core/frame.py Outdated
| if subset is None: | ||
| subset = self.columns.tolist() | ||
| | ||
| # Some features not supported yet |
There was a problem hiding this comment.
i would remove these args then
jreback left a comment
jreback left a comment There was a problem hiding this comment.
cc @pandas-dev/pandas-core if any comments
pandas/core/frame.py Outdated
| .. versionadded:: 1.1.0 | ||
| The returned Series will have a MultiIndex with one level per input |
| also pls merge master |
jreback left a comment
jreback left a comment There was a problem hiding this comment.
small comments, ping on green.
| @@ -0,0 +1,102 @@ | |||
| import numpy as np | |||
| | |||
| import pandas as pd | |||
There was a problem hiding this comment.
move to the methods/ subdir
| Getting some seemingly unrelated test failures from |
| @jreback Green after the CI fixes, thanks for the review |
| thanks @dsaxton very nice! |
3 participants
black pandasThis is picking up where #27350 left off because I think it'd be a nice feature to have. At least one thing that still needs to be done is implementing
binswhen we have only a single column insubset, in which case maybe we can just delegate toSeries.value_counts.