BUG: Summing a sparse boolean series raises TypeError #34220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
5 tasks
jreback requested changes May 17, 2020
pandas/core/arrays/sparse/array.py Outdated
| return values.any().item() | ||
| | ||
| def sum(self, axis=0, *args, **kwargs): | ||
| def sum(self, axis=0, min_count=0, *args, **kwargs): |
Contributor
There was a problem hiding this comment.
can you add to the doc-string
pandas/core/arrays/sparse/array.py Outdated
| count = len(valid_vals) | ||
| sp_sum = valid_vals.sum() | ||
| if self._null_fill_value: | ||
| if count < min_count: |
Contributor
There was a problem hiding this comment.
can you use array_ops/check_below_min_count
jreback approved these changes May 18, 2020
Contributor
| thanks! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
TypeError: sum() got an unexpected keyword argument 'min_count'#25777black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff