Skip to content

REF: make normalize_i8_timestamps cpdef #34476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 31, 2020
Merged

REF: make normalize_i8_timestamps cpdef #34476

merged 2 commits into from
May 31, 2020

Conversation

@jbrockmendel
Copy link
Member

@jbrockmendel jbrockmendel commented May 30, 2020

there's a tiny perf bump, but it all comes from doing own_tz = self.tzinfo up-front instead of accessing self.tz multiple times within Timestamp.normalize. With just the cimport, this is actually slightly slower, which is something of a mystery.

The main upside is that we now only cimport from libconversion, which im hopeful will make some other circular-imports easier to simplify.the perf improvement
@mroeschke mroeschke added the Refactor Internal refactoring of code label May 30, 2020
@mroeschke mroeschke added this to the 1.1 milestone May 30, 2020
@jreback jreback added the Timezones Timezone data dtype label May 31, 2020
@jreback jreback merged commit fde7ec7 into pandas-dev:master May 31, 2020
@jbrockmendel jbrockmendel deleted the ref-ni8 branch May 31, 2020 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Refactor Internal refactoring of code Timezones Timezone data dtype

3 participants

@jbrockmendel @mroeschke @jreback