Skip to content

Add HTML repr for groupby dataframe and series #34926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 35 commits into from
Closed

Add HTML repr for groupby dataframe and series #34926

Changes from 1 commit
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
5e1cb8c
Add html repr for groupby dataframe and series
JulianWgs Jun 22, 2020
9c3df8a
Sort imports with isort in groupby.py
JulianWgs Jun 22, 2020
4a3911a
Improve variable naming
JulianWgs Jul 25, 2020
46f5353
Add display.max_groups to config
JulianWgs Jul 25, 2020
c840c29
Add group display truncation for too many groups
JulianWgs Jul 25, 2020
139bdc6
Implement faster and more scalable list variant
JulianWgs Jul 25, 2020
1020be9
Black config_init
JulianWgs Jul 25, 2020
2e4a6ee
Fix bug which displayed too few rows
JulianWgs Jul 25, 2020
ea2f151
Add test for groupby representation
JulianWgs Jul 26, 2020
2443b80
Delete trailing whitespace in comment
JulianWgs Jul 26, 2020
913afb0
Add test cases for truncated rows and groups
JulianWgs Jul 26, 2020
7efc505
Merge remote-tracking branch 'upstream/master'
JulianWgs Aug 24, 2020
d85fc63
Skip test if lxml is not installed
JulianWgs Sep 3, 2020
778d90d
Move html repr function to io/formats/format.py
JulianWgs Sep 5, 2020
9736007
Add doc string and return type annotation
JulianWgs Sep 5, 2020
7f1937c
Add type annotations for input arg
JulianWgs Sep 5, 2020
388f35d
Fix linting errors
JulianWgs Sep 5, 2020
228e659
Move import to the correct location
JulianWgs Sep 5, 2020
dee1220
Remove pandas type annotations
JulianWgs Oct 3, 2020
57b8bf3
Merge remote-tracking branch 'upstream/master'
JulianWgs Oct 26, 2020
2c5c394
Remove inconsistent use of pd namespace in tests
JulianWgs Oct 28, 2020
669c047
Fix typo and capitalize pandas objs correctly
JulianWgs Oct 30, 2020
8a75299
Change docstring to comment in groupby repr test
JulianWgs Oct 30, 2020
b36177d
Add additional explanation in groupby_repr test
JulianWgs Oct 30, 2020
edff21d
Test more rows in groupby repr when truncated
JulianWgs Nov 11, 2020
580d09b
Test more groups in groupby repr when truncated
JulianWgs Nov 11, 2020
0c948e1
Refactor groups repr html
JulianWgs Jan 3, 2021
e41ff00
Merge remote-tracking branch 'upstream/master'
JulianWgs Jan 3, 2021
ae8721d
Add whatsnew entry for group-by HTML representation
JulianWgs Jan 3, 2021
1c92ed8
Fix test case name
JulianWgs Jan 3, 2021
b92d61f
Rename groupby objects
JulianWgs Jan 3, 2021
579998a
Add case for single and tuple groupby key
JulianWgs Jan 3, 2021
8d8b260
Merge remote-tracking branch 'upstream/master'
JulianWgs Jan 3, 2021
5865cfb
Merge branch 'master' into master
JulianWgs Jul 4, 2021
7a11be8
Move whats new to 1.4.0 release
JulianWgs Jul 4, 2021
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix bug which displayed too few rows 
- max rows per group was calculated with the number of groups in the groupby and did not consider max_groups setting
  • Loading branch information
@JulianWgs
JulianWgs committed Jul 25, 2020
commit 2e4a6eec1f543d40ea318c97a161773195810eb2
4 changes: 3 additions & 1 deletion pandas/core/groupby/groupby.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -545,7 +545,9 @@ def __repr__(self) -> str:

def _repr_html_(self) -> str:
Copy link
Contributor

@jreback jreback Sep 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to reorg this to use a GroupbyFormatter located in pandas/io/formats/groupby.py (it can do pretty much this but just locate the code there) as this is where we keep all of the formatting code.

could also add a .to_string() method but not sure that's actually worth it (maybe open an issue for that).
Copy link
Author

@JulianWgs JulianWgs Sep 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank for the review! Do you mean pandas/io/formats/html.py? Should I add a new function and then just call that function from the above location?
Copy link
Contributor

@jreback jreback Sep 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, i mean pandas/io/formats/format.py (ok to just shove in there is fine, we should split that file up but that's for later).
max_groups = get_option("display.max_groups")
max_rows = max(1, get_option("display.max_rows") // self.ngroups)
max_rows = max(
1, get_option("display.max_rows") // min(max_groups, self.ngroups)
)
group_names = list(self.groups.keys())
truncated = max_groups < self.ngroups
if truncated:
Expand Down