Skip to content

Conversation

@pizzathief
Copy link
Contributor

@pizzathief pizzathief commented Jun 24, 2020

handles the deprecationwarning messages and allows "pytest pandas" to proceed. (see issue #34970)

@pep8speaks
Copy link

Hello @pizzathief! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 14:42: E241 multiple spaces after ','
Line 16:38: E241 multiple spaces after ','

Line 94:1: E302 expected 2 blank lines, found 1
Line 102:1: E305 expected 2 blank lines after class or function definition, found 1

Line 1544:1: E302 expected 2 blank lines, found 1
Line 1549:1: E302 expected 2 blank lines, found 1

Line 1794:14: W291 trailing whitespace
Line 1796:1: E302 expected 2 blank lines, found 1

df = DataFrame({'floats': N / 10 * Series(np.random.random(N)),
'letters': Series(random_letters)})
return df
return df_letters_var()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can leave this like it was and feed df_letters into a new fixture


@pytest.fixture
def epoch_1960_as_pydatetime():
# for origin as 1960-01-01
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you give a doc-string to these (change the comment to a quoted string)

df = s_main_dtypes_var()
return df

def s_main_dtypes_items():
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can inject the fixture to subsequent fixtures

@jreback jreback changed the title Deprecationwarning TST: remove Deprecationwarning Jun 24, 2020
@jreback jreback added the Testing pandas testing functions or related to the test suite label Jun 24, 2020
@jreback jreback changed the title TST: remove Deprecationwarning TST: update incorrectly defined fixtures Jun 24, 2020
@pizzathief pizzathief closed this Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Testing pandas testing functions or related to the test suite

3 participants