BUG/ENH: to_pickle/read_pickle support compression for file ojects #35736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
twoertwein changed the title 
jreback added IO Data 
jreback requested changes Sep 5, 2020
Contributor
jreback left a comment
jreback left a comment There was a problem hiding this comment.
lgtm. doc comment, ping on green.
doc/source/whatsnew/v1.2.0.rst Outdated
| - :meth:`to_csv` passes compression arguments for `'gzip'` always to `gzip.GzipFile` (:issue:`28103`) | ||
| - :meth:`to_csv` did not support zip compression for binary file object not having a filename (:issue: `35058`) | ||
| - :meth:`to_csv` and :meth:`read_csv` did not honor `compression` and `encoding` for path-like objects that are internally converted to file-like objects (:issue:`35677`, :issue:`26124`, and :issue:`32392`) | ||
| - :meth:`to_picke` and :meth:`read_pickle` did not support compression for file-objects (:issue:`26237`) |
Contributor
There was a problem hiding this comment.
can you add all of the issue numbers here that are being closed
Member Author
| @jreback ping |
jreback approved these changes Sep 5, 2020
Contributor
| very nice @twoertwein keep em coming! |
jbrockmendel pushed a commit to jbrockmendel/pandas that referenced this pull request Sep 8, 2020
kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffThis was basically already supported but
to/read_picklesetcompressiontoNonefor file objects.Some functions called
get_filepath_or_buffer(might convert a string to a file object) before callinginfer_compression(doesn't work with file objects). I movedinfer_compressionandget_compression_methodinsideget_filepath_or_buffer.