Skip to content

Conversation

@folger
Copy link

@folger folger commented Aug 28, 2020

paste_windows() now directly used handle return from safeGetClipboardData(CF_UNICODETEXT) as argument for c_wchar_p, which should used safeGlobalLock(handle) instead, while copy_windows(text) doing the right thing.

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry
paste_windows() now directly used handle return from safeGetClipboardData(CF_UNICODETEXT) as argument for c_wchar_p, which should used safeGlobalLock(handle) instead, while copy_windows(text) doing the right thing.
@dsaxton
Copy link
Contributor

dsaxton commented Aug 28, 2020

@folger Is there an issue for this? Usually the first step would be to create one if you feel the code needs to change. Also you'll want to add a test and release note to this PR.

@jreback jreback added the Windows Windows OS label Sep 5, 2020
@folger
Copy link
Author

folger commented Sep 8, 2020

@folger Is there an issue for this? Usually the first step would be to create one if you feel the code needs to change. Also you'll want to add a test and release note to this PR.

@dsaxton I have not created issue for this yet. But it can only be reproduced by python embedded in another application. Not sure how to add a testing case.

@jbrockmendel
Copy link
Member

this is vendored from Pyperclip; have they made this change upstream?

@jreback
Copy link
Contributor

jreback commented Oct 10, 2020

yeah we need this to be pushed upstream, then we can re-vendor a copy here.

@github-actions
Copy link
Contributor

This pull request is stale because it has been open for thirty days with no activity. Please update or respond to this comment if you're still interested in working on this.

@github-actions github-actions bot added the Stale label Nov 10, 2020
@jreback
Copy link
Contributor

jreback commented Jan 1, 2021

closing. this needs to be pushed upstream first (and then we can update our vendored version).

@jreback jreback closed this Jan 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4 participants