TYP: fix typing errors for mypy==0.790, bump mypy version #37108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
Member
simonjayhawkins left a comment
simonjayhawkins left a comment There was a problem hiding this comment.
Thanks @fangchenli for the PR. generally lgtm.
| Hello @fangchenli! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-01-10 03:12:54 UTC |
| | ||
| if isinstance(filepath_or_buffer, os.PathLike): | ||
| # Only @runtime_checkable protocols can be used with instance and class checks | ||
| if isinstance(filepath_or_buffer, os.PathLike): # type: ignore[misc] |
| # Unsupported operand types for + ("List[Optional[str]]" and "List[str]") | ||
| valid = ["infer", None] + sorted( | ||
| _compression_to_extension | ||
| ) # type: ignore[operator] |
simonjayhawkins approved these changes Jan 9, 2021
Member
simonjayhawkins left a comment
simonjayhawkins left a comment There was a problem hiding this comment.
Thanks @fangchenli lgtm pending green
simonjayhawkins requested changes Jan 9, 2021
Member
simonjayhawkins left a comment
simonjayhawkins left a comment There was a problem hiding this comment.
I think we also added the whatnew dependencies on the last bump
Contributor
| looks ok to me, merge master just to confirm. |
Member
| Thanks @fangchenli |
Member
np-dev failures seen on other PRs/master |
luckyvs1 pushed a commit to luckyvs1/pandas that referenced this pull request Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff