Skip to content

ENH: named agg with multiple columns #37627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 12 commits into from
Closed

ENH: named agg with multiple columns #37627

Changes from 2 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
77e6d45
check tuple if column exists
erfannariman Nov 4, 2020
db5ccf6
Merge remote-tracking branch 'upstream/master' into 29268-named-agg-m…
erfannariman Nov 12, 2020
1875e79
Merge branch 'master' into 29268-named-agg-multiple-columns
erfannariman Nov 20, 2020
5ea26ab
added else clause plus test
erfannariman Nov 22, 2020
c66b707
remove np.random from test
erfannariman Nov 22, 2020
ea26fd8
get indexer when tuple is passed, but not multiindex
erfannariman Nov 22, 2020
7e75f88
fix pep8 too long line
erfannariman Nov 22, 2020
ba634f8
pass correct ndim
erfannariman Nov 22, 2020
bbc37e5
Merge branch 'master' into 29268-named-agg-multiple-columns
erfannariman Nov 22, 2020
dbb0c45
try to merge master
erfannariman Sep 12, 2021
76d60e6
remove moved code
erfannariman Sep 12, 2021
5ae5bad
check for sets when checking for missing columns
erfannariman Sep 12, 2021
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion pandas/core/aggregation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -727,7 +727,10 @@ def agg_dict_like(
elif (
isinstance(selected_obj, ABCDataFrame) and k not in selected_obj.columns
):
raise KeyError(f"Column '{k}' does not exist!")
if is_list_like(k):
for c in k:
if c not in selected_obj.columns:
raise KeyError(f"Column '{c}' does not exist!")
Copy link
Contributor

@ivanovmg ivanovmg Nov 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably have else clause.

else: raise KeyError(f"Column '{k}' does not exist!")
Copy link
Member Author

@erfannariman erfannariman Nov 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, good point, added. Thanks.
Copy link
Member Author

@erfannariman erfannariman Nov 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would you think of :

not_found = [c for c in k if c not in selected_obj.columns] raise KeyError(f"Column(s) {', '.join(not_found)} do(es) not exist!")

arg = new_arg

Expand Down