Skip to content

BUG: Dtype was not changed when float was assignt to int column #37680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 21 commits into from
Closed

BUG: Dtype was not changed when float was assignt to int column #37680

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
eafd9ea
Start fixing dtype setting
phofl Nov 6, 2020
c95dcc9
Fix dtype setting for incompatible dtypes
phofl Nov 7, 2020
3788c4d
Add whatsnew
phofl Nov 7, 2020
27d9e35
Fix imports
phofl Nov 7, 2020
23cc926
Change import order
phofl Nov 7, 2020
cee9fc2
Add check for numeric dtype
phofl Nov 7, 2020
97e6da8
Merge branch 'master' of https://github.com/pandas-dev/pandas into 26395
phofl Nov 8, 2020
d1bc870
Parametrize tests
phofl Nov 8, 2020
7e16465
Merge branch 'master' of https://github.com/pandas-dev/pandas into 26395
phofl Nov 9, 2020
4d91e66
Improve dtype casting for at and iat
phofl Nov 10, 2020
d608474
Adjust whatsnew
phofl Nov 10, 2020
1d332e8
Merge branch 'master' of https://github.com/pandas-dev/pandas into 26395
phofl Nov 10, 2020
760c6a1
Run black
phofl Nov 10, 2020
870e927
Fix tests with new dtype conversion
phofl Nov 10, 2020
fa8b331
Fix remaining test
phofl Nov 10, 2020
903be31
Change if condition
phofl Nov 10, 2020
566d769
Fix if condition
phofl Nov 12, 2020
916faa4
Move if condition
phofl Nov 15, 2020
b0699a9
Merge branch 'master' of https://github.com/pandas-dev/pandas into 26395
phofl Nov 15, 2020
33c8424
Merge branch 'master' of https://github.com/pandas-dev/pandas into 26395
phofl Jan 3, 2021
6e7ee82
Move whatsnew
phofl Jan 3, 2021
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Change import order
  • Loading branch information
@phofl
phofl committed Nov 7, 2020
commit 23cc926b146f1f9e6fea86a78b6fdbb6be87ebcf
2 changes: 1 addition & 1 deletion pandas/core/series.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,9 @@

from pandas.core.dtypes.cast import (
convert_dtypes,
infer_dtype_from_scalar,
maybe_cast_to_extension_array,
validate_numeric_casting,
infer_dtype_from_scalar,
)
from pandas.core.dtypes.common import (
ensure_platform_int,
Expand Down