-
- Notifications
You must be signed in to change notification settings - Fork 19.4k
BUG: Bug in loc did not change dtype when complete column was assigned #37749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
Show all changes
40 commits Select commit Hold shift + click to select a range
6450a2c BUG: Bug in loc did not change dtype when complete columne was assigned
phofl 1599c5c Fix list comprehension issue
phofl 4d39612 Fix import order
phofl f9f37cb Add test
phofl 5cf355b Merge branch 'master' of https://github.com/pandas-dev/pandas into 20635
phofl 8d203f9 Change dtype for 32 bit
phofl e35e009 Implement fix and add new test
phofl 4c391da Merge branch 'master' of https://github.com/pandas-dev/pandas into 20635
phofl 71fbf9f Add new column
phofl babcd38 Run black
phofl caa6046 Parametrize tests
phofl 8b95236 Merge branch 'master' of https://github.com/pandas-dev/pandas into 20635
phofl 3b98ee0 Adress review comments
phofl f9b8a59 Change whatsnew wording
phofl 4bef38e Simplify tests
phofl 27ea3e2 Fix related issue
phofl f94277b Add issues
phofl 279e812 Merge branch 'master' of https://github.com/pandas-dev/pandas into 20635
phofl d5f6150 Move import
phofl 706dc6a Delete line
phofl 66d4b4e Fix return value
phofl fa25075 Move and rename tests
phofl 3c06ba6 Fix failing test
phofl a33659c Merge branch 'master' of https://github.com/pandas-dev/pandas into 20635
phofl 0f556c4 Fix pre commit
phofl 181e62a Merge branch 'master' of https://github.com/pandas-dev/pandas into 20635
phofl b759ac9 Remove import
phofl a353930 Fix test
phofl d28e1e1 Add test
phofl 1aa8522 Adress review comments
phofl 1bc0d46 Fix test
phofl 61aab16 Merge branch 'master' of https://github.com/pandas-dev/pandas into 20635
phofl 14fe5a8 Move test
phofl 26b5d6f Fix test
phofl 913ffea Merge branch 'master' of https://github.com/pandas-dev/pandas into 20635
phofl e6e22f3 Fix bug with series to cell
phofl 23f6f3b Merge branch 'master' of https://github.com/pandas-dev/pandas into 20635
phofl 99b87c9 Merge branch 'master' of https://github.com/pandas-dev/pandas into 20635
phofl f97a252 Move whatsnew
phofl 700ce6c Merge branch 'master' of https://github.com/pandas-dev/pandas into 20635
phofl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix bug with series to cell
- Loading branch information
commit e6e22f335e3f3fd674a641a9f18367b75e928728
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this can be the else condtiion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, value can be anything from int, float to numpy array. I think this check is only necessary if we have Series or DataFrame. Maybe with an array?