Skip to content

Conversation

@mroeschke
Copy link
Member

xref #37825

Another script that looks unused and undocumented

@mroeschke mroeschke added this to the 1.2 milestone Nov 14, 2020
Copy link
Member

@jbrockmendel jbrockmendel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, maybe should get an opinion from a windows user

@alimcmaster1
Copy link
Member

LGTM, maybe should get an opinion from a windows user

@simonjayhawkins maybe?

@jreback jreback added the Windows Windows OS label Nov 17, 2020
@simonjayhawkins
Copy link
Member

i tend to use git bash as the terminal rather than anaconda prompt so never use this (or test_fast.bat). Have just tested in anaconda prompt and the scripts both work.

if the scripts are undocumented then I guess no harm in removing.

@mroeschke
Copy link
Member Author

I kept the test_fast.* scripts since they were documented in contributing.rst. I'll move forward with removing this one, thanks

@mroeschke mroeschke merged commit df6f00e into pandas-dev:master Nov 17, 2020
@mroeschke mroeschke deleted the remove_old_scripts branch November 17, 2020 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

5 participants