REF: implement sanitize_masked_array #38398
Merged
+25 −23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
jbrockmendel commented Dec 10, 2020
| data.soften_mask() # set hardmask False if it was True | ||
| data[mask] = fill_value | ||
| else: | ||
| data = data.copy() |
Member Author
There was a problem hiding this comment.
removing this copy does not break any tests, not clear why it is needed
…f-construction
jreback added Constructors luckyvs1 pushed a commit to luckyvs1/pandas that referenced this pull request Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The recarray handling in internals.construction is inconsistent with the other recarray handling. Hopefully I can get that sorted out and then we can re-use sanitize_masked_array there too.