BUG: GH38672 SeriesGroupBy.value_counts for categorical #38796
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Unobserved categories in Series were being dropped in value_counts, which was inconsistent with Series.value_counts
jreback requested changes Dec 30, 2020
Contributor
| also pls add a whatsnew note to 1.3, bug fixes under categorical is fine. so i guess this was just not tested before. |
Contributor Author
No worries. I think it might be more consistent with past whatsnew files to place it under Groupby/resample/rolling though. Happy to do what I'm told though 😄 |
jreback requested changes Dec 31, 2020
jreback approved these changes Dec 31, 2020
Contributor
| thanks @venaturum |
Contributor
luckyvs1 pushed a commit to luckyvs1/pandas that referenced this pull request Jan 20, 2021
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Unobserved categories in Series were being dropped in value_counts, which was inconsistent with Series.value_counts
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff