Skip to content

ENH: implement FloatingArray.round() #38866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from
Closed

ENH: implement FloatingArray.round() #38866

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
1df9bf7
add test for nullable float
arw2019 Dec 31, 2020
192ebad
implement round method for FloatingArray
arw2019 Dec 31, 2020
6403026
use pytest fixture
arw2019 Dec 31, 2020
253d279
review: rewriting using _apply
arw2019 Jan 4, 2021
3e0d605
Merge branch 'master' of https://github.com/pandas-dev/pandas into GH…
arw2019 Jan 4, 2021
fe19597
remove explicit FloatingArray reference from _apply
arw2019 Jan 4, 2021
b557a50
move _apply, round to NumericArray
arw2019 Jan 4, 2021
85e6d4f
move _apply, round to NumericArray
arw2019 Jan 4, 2021
f79c0cd
typing, consistency with Series.round
arw2019 Jan 4, 2021
d1cd6d8
whatsnew
arw2019 Jan 4, 2021
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
move _apply, round to NumericArray
  • Loading branch information
@arw2019
arw2019 committed Jan 4, 2021
commit 85e6d4fdc9323b2ecc0a0ff167997216e8f97a4c
11 changes: 11 additions & 0 deletions pandas/core/arrays/numeric.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,3 +130,14 @@ def _arith_method(self, other, op):
)

return self._maybe_mask_result(result, mask, other, op_name)

def _apply(self, func, **kwargs):
values = self._data[~self._mask]
Copy link
Contributor

@jreback jreback Jan 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a doc-string
Copy link
Member

@jorisvandenbossche jorisvandenbossche Jan 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you actually need to subset the _data with the mask in this case, as "round" should work on all values, and I can't think of a case where it would error by being called on the "invalid" values hidden by the mask.

Of course, if many values are masked, we might be calculating round on too many values. But doing the filter operation / copy also takes time. Maybe something to time both ways.
values = np.round(values, **kwargs)
Copy link
Contributor

@jreback jreback Jan 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be func :->

data = np.zeros(self._data.shape)
data[~self._mask] = values
return type(self)(data, self._mask)
Copy link
Member

@jorisvandenbossche jorisvandenbossche Jan 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mask needs to be copied I think? (result should not share a mask with the original array, because otherwise editing one can modify the other. We should probably also test this)
Copy link
Contributor Author

@arw2019 arw2019 Jan 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good point (and actually the same bug exists already in my implementation of to_numeric for EAs - #38974). I'll fix this and add tests

def round(self, decimals=0):
return self._apply(np.round, decimals=decimals)