Skip to content

Conversation

@jmishra01
Copy link

@jmishra01 jmishra01 commented Jan 20, 2021

@jmishra01 jmishra01 changed the title To fix bug #39166 BUG: Pandas DataFrame with python own collection apply function seems has some bug. #39166 Jan 20, 2021
@jmishra01 jmishra01 changed the title BUG: Pandas DataFrame with python own collection apply function seems has some bug. #39166 Fixes for bug of apply function of DataFrame reported in issues #39166 Jan 20, 2021
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

first thing to add is tests

@jreback jreback added the Apply Apply, Aggregate, Transform, Map label Jan 20, 2021
@jreback jreback changed the title Fixes for bug of apply function of DataFrame reported in issues #39166 BUG: of apply function of DataFrame reported in issues #39166 Jan 20, 2021
ser.name = name
yield ser
# To fix issue of #39166
yield ser.copy()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the entire point of series_generator is to avoid creating a bunch of Series objects. if this is too buggy to be viable, might as well remove the whole method and just use self.obj.iloc[i] for i in range(len(self.obj))

@jmishra01 jmishra01 closed this Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Apply Apply, Aggregate, Transform, Map

3 participants