CLN: localising scope of functions in Styler #39533
Closed
+30 −31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
| i would rather go the other way. slimming the logic in the class and pulling out function to the module level scope. |
Contributor Author
| @jreback ok, ill close this and if I get a chance submit PRs that try to do that instead. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Stylerhas a mixture of function placements, e.g. outer scope, or as class methods or inner scope of class methods.This PR has moved two outer scope functions to inner scope of class methods, where they are only used / relevant for that section, to be more consistent with the rest of the class.