BUG: Breaking change to offsets.pyx - MonthOffset

[Pawel-Kranzberg]

Add ability to use class MonthBegin as a period.
It would address #38914 and #38859.

• closes BUG: Timestamp.to_period() fails for freq="MS" #38914 ENH: Implement '_period_dtype_code' attribute to 'pandas._libs.tslibs.offsets.MonthBegin' #38859
• tests added / passed
• Ensure all linting tests pass, see here for how to run them
• whatsnew entry

[jreback]

can you add a test for this that fails on current master.

you also need to adjust tests for this change.

[jbrockmendel]

im wary of this. inevitably someone is going to be confused as to why Period(foo, freq= BusinessMonthEnd) isnt different from Period(foo, freq= BusinessMonthBegin)

If we were doing this from scratch, I would keep DateOffsets totally unrelated to PeriodDtypes.

[Pawel-Kranzberg]

can you add a test for this that fails on current master.

you also need to adjust tests for this change.

done

[jbrockmendel]

I find this really sketchy. MonthBegin doesn't correspond to a Period. I just dont understand the motivation here.

[github-actions]

This pull request is stale because it has been open for thirty days with no activity. Please update or respond to this comment if you're still interested in working on this.

[simonjayhawkins]

@Pawel-Kranzberg can you address #39887 (comment)

[Pawel-Kranzberg]

@Pawel-Kranzberg can you address #39887 (comment)

I plan to do it next week. In a nutshell, there are existing issues that reference the need for MonthBegin as Offset and I also faced it during a project at work. Ended up coding a workaround that made code maintenance more challenging.

[mroeschke]

Thanks for the PR, but it appears that it has gotten stale and there's some uncertainty that around this proposed change.

Closing, but glad to have you help on other open issues.