REF: remove internal Block usage from FrameColumnApply #40166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
jorisvandenbossche added Refactor 
jbrockmendel reviewed Mar 2, 2021
pandas/core/apply.py Outdated
| # GH#35462 re-pin mgr in case setitem changed it | ||
| ser._mgr = mgr | ||
| blk.values = arr | ||
| ser._mgr.set_values(arr) |
Member
There was a problem hiding this comment.
small perf gain by using mgr instead of ser._mgr
jbrockmendel reviewed Mar 2, 2021
pandas/core/internals/managers.py Outdated
| """ | ||
| raise NotImplementedError("Use series._values[loc] instead") | ||
| | ||
| def set_values(self, values): |
Member
| small comments, otherwise LGTM |
jreback approved these changes Mar 2, 2021
Contributor
jreback left a comment
jreback left a comment There was a problem hiding this comment.
lgtm ex @jbrockmendel comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
In the
applycode, there is still one case where we are directly using the internal blocks. This moves that to a method on the manager, so we don't have to interact directly with the blocks (which ideally we don't want outside of the internals, and let's ArrayManager cleanly support this as well).For the rest it still updates the Series' values in place, preserving the performance trick.
cc @jbrockmendel @rhshadrach