Skip to content

[ArrowStringArray] fix test_astype_int, test_astype_float #41018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 31, 2021
Merged

[ArrowStringArray] fix test_astype_int, test_astype_float #41018

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
683da0b
[ArrowStringArray] fix test_astype_int, test_astype_float
simonjayhawkins Apr 18, 2021
cd6edc9
Merge remote-tracking branch 'upstream/master' into ArrowStringArray.…
simonjayhawkins Apr 29, 2021
c16e2ec
Merge remote-tracking branch 'upstream/master' into ArrowStringArray.…
simonjayhawkins May 31, 2021
a0f7035
use cast, fix other EA
simonjayhawkins May 31, 2021
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge remote-tracking branch 'upstream/master' into ArrowStringArray.… 
…astype
  • Loading branch information
@simonjayhawkins
simonjayhawkins committed May 31, 2021
commit c16e2eccab6e5c0d31f04443839cb258dd4ad1c8
2 changes: 0 additions & 2 deletions pandas/tests/arrays/string_/test_string.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,9 +349,7 @@ def test_astype_nullable_int(dtype):

def test_astype_float(dtype, any_float_allowed_nullable_dtype):
# Don't compare arrays (37974)

ser = pd.Series(["1.1", pd.NA, "3.3"], dtype=dtype)

result = ser.astype(any_float_allowed_nullable_dtype)
expected = pd.Series([1.1, np.nan, 3.3], dtype=any_float_allowed_nullable_dtype)
tm.assert_series_equal(result, expected)
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.