Skip to content

BUG: Series[int].loc setitem with Series[int] results in Series[float] #41644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 8, 2021
Merged

BUG: Series[int].loc setitem with Series[int] results in Series[float] #41644

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c9b617b
BUG: Series[int].loc setitem with Series[int] results in Series[float]
simonjayhawkins May 24, 2021
46ee828
pre-commit fix
simonjayhawkins May 24, 2021
776c144
Merge remote-tracking branch 'upstream/master' into can-hold-element
simonjayhawkins Jun 1, 2021
f8f9bb5
remove backport fix
simonjayhawkins Jun 1, 2021
0ab9c47
Merge remote-tracking branch 'upstream/master' into can-hold-element
simonjayhawkins Jun 4, 2021
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove backport fix
  • Loading branch information
@simonjayhawkins
simonjayhawkins committed Jun 1, 2021
commit f8f9bb5207ca52a9706a8ef87b10cba1b4600cdf
8 changes: 0 additions & 8 deletions pandas/core/internals/blocks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -781,14 +781,6 @@ def _replace_list(
# so un-tile here
return self.replace(src_list, dest_list[0], inplace, regex)

# https://github.com/pandas-dev/pandas/issues/40371
# the following pairs check code caused a regression so we catch that case here
# until the issue is fixed properly in can_hold_element

# error: "Iterable[Any]" has no attribute "tolist"
if hasattr(src_list, "tolist"):
src_list = src_list.tolist() # type: ignore[attr-defined]

# Exclude anything that we know we won't contain
pairs = [
(x, y) for x, y in zip(src_list, dest_list) if self._can_hold_element(x)
Expand Down