BUG: MultiIndex.difference incorrectly raising TypeError when indexes contain non-sortable entries #41915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| msg = "sort order is undefined for incomparable objects" | ||
| with tm.assert_produces_warning(RuntimeWarning, match=msg): | ||
| result = idx.difference(other) | ||
| tm.assert_index_equal(result, idx) |
Member
There was a problem hiding this comment.
behavior change? needs a release note?
simonjayhawkins added Index 
Member
| Can you check the performance impact here? (xref #41929 (comment)) |
simonjayhawkins changed the title 
Member Author
ran asvs overnight and no obvious standouts. re-running a subset now to be on the safe side |
Member Author
| yep, all noise |
Contributor
| @meeseeksdev backport 1.3.x |
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Jun 17, 2021
…raising TypeError when indexes contain non-sortable entries
| Something went wrong ... Please have a look at my logs. |
jreback pushed a commit that referenced this pull request Jun 17, 2021
…peError when indexes contain non-sortable entries (#42081) Co-authored-by: jbrockmendel <jbrockmendel@gmail.com>
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
… contain non-sortable entries (pandas-dev#41915)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.