TYP: changed variable cat_array to cat_array_list in dtypes.py and arr_list in categorical.py #44664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
| umm what are these in reference to? |
Contributor Author
nickleus27 changed the title 
jreback requested changes Dec 1, 2021
jreback approved these changes Dec 3, 2021
Contributor
| thanks @nickleus27 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
xref #37715
My apologies, I pushed hastily on my previous branch assign_err and did not check the diff of the files i was pushing. I accidentally pulled when i should have merged and I pushed a bunch of other peoples commits. These are my previous changes.