Skip to content

BUG: SparseArray.__floordiv__ not matching non-Sparse Series behavior #44928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 19, 2021
Merged

BUG: SparseArray.__floordiv__ not matching non-Sparse Series behavior #44928

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3b3816d
BUG: SparseArray.__floordiv__ not matching non-Sparse Series behavior
jbrockmendel Dec 16, 2021
0644807
Merge branch 'master' into bug-sparse-arith
jbrockmendel Dec 17, 2021
9dce9f5
xfail on older numpy
jbrockmendel Dec 17, 2021
96a0c08
simplify
jbrockmendel Dec 18, 2021
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
simplify
  • Loading branch information
@jbrockmendel
jbrockmendel committed Dec 18, 2021
commit 96a0c089c4404bfcc0da098f972e030b6db677ad
12 changes: 3 additions & 9 deletions pandas/core/arrays/sparse/array.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,24 +220,18 @@ def _sparse_array_op(
left_sp_values = left.sp_values
right_sp_values = right.sp_values

sparse_op = getattr(splib, opname)

if (
name in ["floordiv", "mod"]
and (right == 0).any()
and left.dtype.kind in ["i", "u"]
):
# Match the non-Sparse Series behavior
if name == "floordiv":
# error: Module has no attribute "sparse_floordiv_float64"
sparse_op = splib.sparse_floordiv_float64 # type: ignore[attr-defined]
else:
# error: Module has no attribute "sparse_mod_float64"
sparse_op = splib.sparse_mod_float64 # type: ignore[attr-defined]

opname = f"sparse_{name}_float64"
left_sp_values = left_sp_values.astype("float64")
right_sp_values = right_sp_values.astype("float64")

sparse_op = getattr(splib, opname)

with np.errstate(all="ignore"):
result, index, fill = sparse_op(
left_sp_values,
Expand Down