BUG/ENH: Translate CSS border properties for `Styler.to_excel` #45312

tehunter · 2022-01-11T13:27:06Z

checks an item on BUG: Styler.to_excel does not export styles and formats correctly #42276 ("Border styles bug")
tests added / passed
Ensure all linting tests pass, see here for how to run them
whatsnew entry

… tests

…/GH42276)

pep8speaks · 2022-01-11T13:27:10Z

Hello @tehunter! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2022-02-10 13:27:41 UTC

pandas/io/formats/css.py

attack68

can you also look to add a roundtrip test in pandas/tests/io/excel/test_style.py

pandas/tests/io/formats/test_css.py

…into style-border-css

Addressing PR change requests

tehunter · 2022-01-12T20:01:52Z

Any idea what could be causing the failure? It's something related to filesystems in test_arrowparquet_options, which I haven't touched.

pandas/io/formats/css.py

pandas/tests/io/formats/test_css.py

attack68 · 2022-01-13T17:23:57Z

Looking really good, especially the style round trip. Just one or two comments for optimisation.

Co-authored-by: JHM Darbyshire <24256554+attack68@users.noreply.github.com>

…into style-border-css

attack68 · 2022-01-16T16:40:22Z

can you show a test that exerices this at a high level as well

Its difficult to test this since you have to write to excel and then read that the file rendered correctly.

The round trip tests I requested in test_style.py now do this: explicitly they check that:

a) The styled dataframe (with a border) is different to the unstyled dataframe (without border)
b) that the excel file created is read in correctly by openpyxl and has the border styles as expected.

tehunter · 2022-01-16T20:06:34Z

needs a whats new 1.5.0, (maybe 1.4.1 if it can be backported).

Do I write the entry or does a maintainer do that? I propose 2 entries along the lines of:

Bug Fix: Fixed bug in CSSToExcelConverter leading to TypeError when border color provided without border style for xlsxwriter engine (GH42276)
Enhancement / Styler Enhancements: Added the ability to render border and border-{side} CSS properties in Excel (GH42276)

jreback · 2022-01-16T20:14:13Z

@tehunter u add them

jreback · 2022-01-17T14:04:58Z

looks fine (but before i resolved i think the doc-build was failing) so let's check that.

jreback · 2022-01-17T16:34:02Z

yeah these are failing: https://github.com/pandas-dev/pandas/runs/4841791532?check_suite_focus=true

doc/source/whatsnew/v1.5.0.rst

pandas/tests/io/formats/test_css.py

pandas/io/formats/css.py

Co-authored-by: JHM Darbyshire <24256554+attack68@users.noreply.github.com>

tehunter · 2022-01-17T21:34:22Z

@github-actions pre-commit

attack68 · 2022-02-08T17:29:12Z

@tehunter if you get a chance to merge with main, i can take a look at the CI errors you are getting

…into style-border-css

jreback · 2022-02-09T00:55:41Z

doc/source/whatsnew/v1.5.0.rst

+Styler
+^^^^^^
+
+- Fixed bug in :class:`CSSToExcelConverter` leading to ``TypeError`` when border color provided without border style for ``xlsxwriter`` engine (:issue:`42276`)


just put this in the I/O section

jreback · 2022-02-11T00:56:23Z

thanks @tehunter

…s-dev#45312)

tehunter added 5 commits January 11, 2022 08:09

BUG/ENH: Improve border CSS parsing (GH42276)

9543045

Fix issue where width 'pt' is not recognized and fix border shorthand…

d071893

… tests

BUG: Xlsxwriter crashes on to_excel with only 'border-color' (GH30008…

fb31af3

…/GH42276)

DOC: Update documentation to resolve GH42267

9827ad9

Merge remote-tracking branch 'upstream/master' into tmp

67b9fff

tehunter added 5 commits January 11, 2022 08:34

CLN: Comply with PEP8 checks

aaac09a

CLN: Remove whitespace

f6af38a

Fixes from pre-commit [automated commit]

9af2869

BUG: Fixed issue with invalid colors generating borders

13c3fa6

Merged origin/style-border-css

3d067d0

This comment has been minimized.

Sign in to view

Fixes from pre-commit [automated commit]

18a6a41

attack68 reviewed Jan 11, 2022

View reviewed changes

pandas/io/formats/css.py Outdated Show resolved Hide resolved

attack68 reviewed Jan 11, 2022

View reviewed changes

pandas/io/formats/css.py Show resolved Hide resolved

attack68 reviewed Jan 11, 2022

View reviewed changes

pandas/io/formats/css.py Outdated Show resolved Hide resolved

attack68 requested changes Jan 11, 2022

View reviewed changes

attack68 reviewed Jan 11, 2022

View reviewed changes

pandas/tests/io/formats/test_css.py Show resolved Hide resolved

tehunter added 5 commits January 11, 2022 17:29

Merge remote-tracking branch 'upstream/master' into style-border-css

a5cd011

Merge branch 'style-border-css' of https://github.com/tehunter/pandas …

f3b1d13

…into style-border-css

Cleaned code and improved test (GH45312)

905a6ca

Addressing PR change requests

Merge remote-tracking branch 'upstream/master' into style-border-css

cce6457

Fixes from pre-commit [automated commit]

7e6f5f1

attack68 reviewed Jan 13, 2022

View reviewed changes

pandas/io/formats/css.py Outdated Show resolved Hide resolved

attack68 reviewed Jan 13, 2022

View reviewed changes

pandas/tests/io/formats/test_css.py Outdated Show resolved Hide resolved

tehunter and others added 3 commits January 13, 2022 20:25

Clean border_expander

337b2f4

Co-authored-by: JHM Darbyshire <24256554+attack68@users.noreply.github.com>

Eliminate redundant test expansions

cd28198

Merge branch 'style-border-css' of https://github.com/tehunter/pandas …

ed5d5ca

…into style-border-css

Updated docstrings and what's new entry

50f93a1

attack68 approved these changes Jan 16, 2022

View reviewed changes

jreback added this to the 1.5 milestone Jan 17, 2022

Merge branch 'main' into style-border-css

88590dc

jreback approved these changes Jan 17, 2022

View reviewed changes

attack68 reviewed Jan 17, 2022

View reviewed changes

doc/source/whatsnew/v1.5.0.rst Outdated Show resolved Hide resolved

attack68 reviewed Jan 17, 2022

View reviewed changes

pandas/tests/io/formats/test_css.py Outdated Show resolved Hide resolved

attack68 reviewed Jan 17, 2022

View reviewed changes

pandas/io/formats/css.py Outdated Show resolved Hide resolved

tehunter and others added 3 commits January 17, 2022 16:28

Update doc/source/whatsnew/v1.5.0.rst

4785dc4

Co-authored-by: JHM Darbyshire <24256554+attack68@users.noreply.github.com>

Update pandas/tests/io/formats/test_css.py

93cfb92

Co-authored-by: JHM Darbyshire <24256554+attack68@users.noreply.github.com>

Resolved doc-build check

dec6920

Fixes from pre-commit [automated commit]

17dc457

attack68 and others added 3 commits February 8, 2022 18:30

Merge branch 'main' into style-border-css

21bb3f6

Merge remote-tracking branch 'upstream/main' into style-border-css

15e8a5d

Merge branch 'style-border-css' of https://github.com/tehunter/pandas …

d9f2ed3

…into style-border-css

jreback reviewed Feb 9, 2022

View reviewed changes

Pre-commit cleanup

fa15e0a

jreback merged commit 65ecb90 into pandas-dev:main Feb 11, 2022

attack68 mentioned this pull request Feb 13, 2022

BUG: Styler.to_excel does not export styles and formats correctly #42276

Open

5 tasks

phofl pushed a commit to phofl/pandas that referenced this pull request Feb 14, 2022

BUG/ENH: Translate CSS border properties for Styler.to_excel (panda…

b7e0544

…s-dev#45312)

yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022

BUG/ENH: Translate CSS border properties for Styler.to_excel (panda…

3ff3bb0

…s-dev#45312)

tehunter mentioned this pull request Sep 19, 2022

BUG: df.to_excel fails for "border-style: hair" with xlsxwriter #48649

Closed

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

BUG/ENH: Translate CSS border properties for `Styler.to_excel` #45312

BUG/ENH: Translate CSS border properties for `Styler.to_excel` #45312

Uh oh!

tehunter commented Jan 11, 2022 •

edited

Loading

pep8speaks commented Jan 11, 2022 •

edited

Loading

This comment has been minimized.

Uh oh!

Uh oh!

Uh oh!

attack68 left a comment

Uh oh!

tehunter commented Jan 12, 2022

Uh oh!

Uh oh!

attack68 commented Jan 13, 2022

attack68 commented Jan 16, 2022

tehunter commented Jan 16, 2022

jreback commented Jan 16, 2022

jreback commented Jan 17, 2022

jreback commented Jan 17, 2022

Uh oh!

Uh oh!

Uh oh!

tehunter commented Jan 17, 2022

attack68 commented Feb 8, 2022

jreback Feb 9, 2022

jreback commented Feb 11, 2022

Labels

4 participants

Uh oh!

BUG/ENH: Translate CSS border properties for Styler.to_excel #45312

BUG/ENH: Translate CSS border properties for Styler.to_excel #45312

Uh oh!

Conversation

tehunter commented Jan 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

pep8speaks commented Jan 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Comment last updated at 2022-02-10 13:27:41 UTC

This comment has been minimized.

Uh oh!

Uh oh!

Uh oh!

attack68 left a comment

Choose a reason for hiding this comment

Uh oh!

tehunter commented Jan 12, 2022

Uh oh!

Uh oh!

attack68 commented Jan 13, 2022

attack68 commented Jan 16, 2022

tehunter commented Jan 16, 2022

jreback commented Jan 16, 2022

jreback commented Jan 17, 2022

jreback commented Jan 17, 2022

Uh oh!

Uh oh!

Uh oh!

tehunter commented Jan 17, 2022

attack68 commented Feb 8, 2022

jreback Feb 9, 2022

Choose a reason for hiding this comment

jreback commented Feb 11, 2022

Labels

4 participants

BUG/ENH: Translate CSS border properties for `Styler.to_excel` #45312

BUG/ENH: Translate CSS border properties for `Styler.to_excel` #45312

tehunter commented Jan 11, 2022 •

edited

Loading

pep8speaks commented Jan 11, 2022 •

edited

Loading