BUG: fix bug where appending unordered `CategoricalIndex` variables overrides index #47841

GivyBoy · 2022-07-24T22:42:35Z

closes Concatenating unordered CategoricalIndex overrides indices #24845
Tests added and passed if fixing a bug or adding a new feature
All code checks passed.
Added type annotations to new arguments/methods/functions.
Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

pandas/core/indexes/category.py

GivyBoy · 2022-08-08T22:47:02Z

Hi @mroeschke or @jreback, I would love to have some feedback on this PR. Thanks a lot!

doc/source/whatsnew/v1.5.0.rst

… overrides index (pandas-dev#24845)

GivyBoy · 2022-08-12T22:43:08Z

Hi @mroeschke, I have made the edits. I thought something was wrong with my commit, then I realized that a PR was merged with the same three errors. Could you explain, if possible, why this is happening? Thanks!

mroeschke · 2022-08-15T17:03:40Z

Hi @mroeschke, I have made the edits. I thought something was wrong with my commit, then I realized that a PR was merged with the same three errors. Could you explain, if possible, why this is happening? Thanks!

We had some unrelated CI issues lately. Could you merge in main once more?

GivyBoy · 2022-08-16T00:56:33Z

Hi @mroeschke! I merged and I am receiving errors that I'm not receiving when I run the tests on my local machine.

mroeschke · 2022-08-16T01:57:00Z

Hi @mroeschke! I merged and I am receiving errors that I'm not receiving when I run the tests on my local machine.

We're experience a similar error on main that is affecting all builds. Merging one more time should fix it.

GivyBoy · 2022-08-16T04:06:43Z

It passed all test cases, @mroeschke. Thanks a lot for your guidance!

mroeschke · 2022-08-16T18:38:43Z

Thanks for sticking with all the reviews and being responsive @GivyBoy!

… overrides index (pandas-dev#47841) BUG: fix bug where appending unordered ``CategoricalIndex`` variables overrides index (pandas-dev#24845)

jreback requested changes Jul 24, 2022

View reviewed changes

pandas/core/indexes/category.py Outdated Show resolved Hide resolved

GivyBoy marked this pull request as ready for review July 26, 2022 18:58

mroeschke added the Categorical Categorical Data Type label Jul 26, 2022

GivyBoy force-pushed the GH24845v2 branch from 240cb8e to 14ad4bc Compare July 31, 2022 17:16

GivyBoy changed the title ~~updated the code in accordance with GH24845~~ BUG: fix bug where appending unordered CategoricalIndex variables overrides index Jul 31, 2022

GivyBoy requested a review from jreback August 1, 2022 13:12

GivyBoy force-pushed the GH24845v2 branch from 14ad4bc to 1eb443e Compare August 8, 2022 12:47

mroeschke reviewed Aug 8, 2022

View reviewed changes

doc/source/whatsnew/v1.5.0.rst Outdated Show resolved Hide resolved

GivyBoy force-pushed the GH24845v2 branch 3 times, most recently from a3ded27 to 12367c0 Compare August 9, 2022 03:00

mroeschke reviewed Aug 9, 2022

View reviewed changes