BUG: fix valueError for groupby with empty inputs when sample method is called #48484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
| Looks pretty good. Could use a whatsnew note in |
rhshadrach requested changes Sep 10, 2022
Member
rhshadrach left a comment
rhshadrach left a comment There was a problem hiding this comment.
Forgot to submit the request.
pandas/tests/groupby/test_sample.py Outdated
Comment on lines 148 to 149
| result = DataFrame({"a": [], "b": []}) | ||
| expected = result.groupby("a").sample() |
Member
There was a problem hiding this comment.
nit: result should be the result that is being tested, expected should be what we expect. Can you switch these?
rhshadrach requested changes Sep 10, 2022
mroeschke approved these changes Sep 12, 2022
Member
| Thanks @Th3nn3ss |
1 task
noatamir pushed a commit to noatamir/pandas that referenced this pull request Nov 9, 2022
…is called (pandas-dev#48484) * fix valueError for empty inputs for groupby sample * add to whatsnew/v1.6.0.rst doc * refactor test for groupby sample * fix duplicate assert in test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.