BUG: groupby(..., dropna=False) drops null values with categorical grouper #48981
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…pby_dropna_filtering
…pby_dropna_filtering
mroeschke added Groupby Missing-data …ach/pandas into groupby_dropna_filtering � Conflicts: � pandas/core/groupby/grouper.py � pandas/tests/groupby/test_groupby_dropna.py
…pby_dropna_filtering
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.cc @mroeschke - Still writing / cleaning up tests.
sort=Falsestill doesn't work, and I'm not sure if it could be made to. We'd like to insert the null value as the proper code in the order that it appears (e.g. 0 if the null value is first), but categorical assumes all categories are coded 0, ..., n-1. So not sure if this approach will ever work withsort=Falseat this point.