Bug: Don't intercept TypeError in DataFrame.agg #49505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

sarvaSanjay wants to merge 1 commit into pandas-dev:main from sarvaSanjay:shiny-new-feature

Contributor

sarvaSanjay commented Nov 3, 2022 •

edited

Loading

closes Bug: Don't intercept TypeError in DataFrame.agg #49399 (Replace xxxx with the GitHub issue number)
Tests added and passed if fixing a bug or adding a new feature
All code checks passed.
Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

Update apply.py

d8d53e5

jbrockmendel requested a review from rhshadrach

November 3, 2022 18:41

Member

rhshadrach commented Nov 3, 2022

Thanks for the PR! Could you update the title by clicking the edit button here:

to be a bit more descriptive? It can even just be the title from the corresponding issue.

I also suspect there will be a number of test failures; we check the error message and that message will now need to be updated.

mroeschke added Clean Apply labels

sarvaSanjay changed the title ~~Update apply.py~~ Bug: Don't intercept TypeError in DataFrame.agg

Contributor Author

sarvaSanjay commented Nov 3, 2022

@rhshadrach,
Thanks for your msg. Sorry about the title. I believe it's better now. Also regarding the test failures, I believe they will have to be fixed at your end? Or would I have to change something in the test folder?

Member

rhshadrach commented Nov 4, 2022

Title looks great - thanks!

Or would I have to change something in the test folder?

You're changing tested behavior of pandas, and that is going to cause the tests to "fail". The tests that have failed need to be updated with the correct error types and messages.

Contributor

github-actions bot commented Dec 5, 2022

This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this.

github-actions bot added the Stale label

Member

rhshadrach commented Dec 5, 2022

Closing as stale. @sarvaSanjay - if you'd like to continue comment here and we can reopen.

rhshadrach closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment