ENH/CoW: use lazy copy in set_index method #49557
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
73 tasks
Member
jorisvandenbossche left a comment
jorisvandenbossche left a comment There was a problem hiding this comment.
Thanks! Looking good, just added some minor comments on the test
jorisvandenbossche approved these changes Nov 15, 2022
Member
| Thanks! |
MarcoGorelli pushed a commit to MarcoGorelli/pandas that referenced this pull request Nov 18, 2022
mliu08 pushed a commit to mliu08/pandas that referenced this pull request Nov 27, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Copy-on-Write in
set_indexThis PR is part of an effort to implement the Copy-on-Write implementation mentioned in ENH / CoW: Use the "lazy copy" (with Copy-on-Write) optimization in more methods where appropriate #49473. More detail in this proposal https://docs.google.com/document/d/1ZCQ9mx3LBMy-nhwRl33_jgcvWo9IWdEfxDNQ2thyTb0/edit / with discussions in Proposal for future copy / view semantics in indexing operations #36195