Skip to content

API: Series(floaty, dtype=inty) #49609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Dec 15, 2022
Merged

API: Series(floaty, dtype=inty) #49609

merged 13 commits into from
Dec 15, 2022

Conversation

@jbrockmendel
Copy link
Member

@jbrockmendel jbrockmendel commented Nov 9, 2022

@jbrockmendel jbrockmendel added API Design Constructors Series/DataFrame/Index/pd.array Constructors labels Nov 14, 2022
@jbrockmendel jbrockmendel mentioned this pull request Nov 17, 2022
Merged
5 tasks
@mroeschke
Copy link
Member

mroeschke commented Nov 23, 2022

If a user want to cast to int with float data, would they have to do ser.round().astype(int) (assuming the "safe casting" astype isn't implemented)?
@jbrockmendel
Copy link
Member Author

jbrockmendel commented Nov 23, 2022

If a user want to cast to int with float data, would they have to do ser.round().astype(int) (assuming the "safe casting" astype isn't implemented)?

Yes.
@mroeschke
Copy link
Member

mroeschke commented Nov 24, 2022

Cool could you add this "if you want to do this" behavior in the whatsnew?
@mroeschke
Copy link
Member

mroeschke commented Nov 29, 2022

cc @seberg just noting that pandas probably will move forward with this behavior which doesn't currently align with numpy
@MarcoGorelli MarcoGorelli self-requested a review December 13, 2022 19:28
phofl
phofl reviewed Dec 13, 2022
View reviewed changes
Copy link
Member

@phofl phofl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment, otherwise lgtm
mroeschke
mroeschke approved these changes Dec 13, 2022
View reviewed changes
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me besides @phofl comment
MarcoGorelli
MarcoGorelli approved these changes Dec 13, 2022
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, nice!
@phofl phofl added this to the 2.0 milestone Dec 15, 2022
@phofl phofl merged commit 00fa270 into pandas-dev:main Dec 15, 2022
@phofl
Copy link
Member

phofl commented Dec 15, 2022

thx @jbrockmendel
@jbrockmendel jbrockmendel mentioned this pull request Dec 15, 2022
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API Design Constructors Series/DataFrame/Index/pd.array Constructors

4 participants

@jbrockmendel @mroeschke @phofl @MarcoGorelli